🎨 [Frontend] PO Center: don't list registered users in Review users section#9030
Merged
odeimaiz merged 4 commits intoITISFoundation:masterfrom Apr 15, 2026
Merged
Conversation
odeimaiz
added
t:enhancement
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the PO Center “Users Pending” view to ensure the “Reviewed users” list excludes users who have already completed registration, aligning the frontend behavior with the new backend registered filter introduced in #9024.
Changes:
- Adjusts the UI description text to reflect “reviewed but not yet registered” users.
- Adds
registered=falseto the reviewed-users request parameters in the PO Center pending users view. - Extends the
poUsers.getReviewedUsersresource endpoint to accept aregisteredquery parameter.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
services/static-webserver/client/source/class/osparc/po/UsersPending.js |
Filters reviewed users to only those not yet registered; updates intro label text. |
services/static-webserver/client/source/class/osparc/data/Resources.js |
Adds registered={registered} to the reviewed users endpoint URL template. |
odeimaiz
requested review from
GitHK,
bisgaard-itis,
giancarloromeo,
matusdrobuliak66 and
pcrespov
giancarloromeo
approved these changes
Apr 15, 2026
GitHK
approved these changes
Apr 15, 2026
pcrespov
approved these changes
Apr 15, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Updates the PO Center “Users Pending” view to ensure the “Reviewed users” list excludes users who have already completed registration, aligning the frontend behavior with the new backend registered filter introduced in #9024.
Related issue/s
How to test
Dev-ops